generated from fastai/nbdev_template
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for FSDP+QLoRA and DeepSpeed ZeRO3+QLoRA #1416
Merged
younesbelkada
merged 14 commits into
huggingface:main
from
pacman100:smangrul/fsdp+qlora
Mar 13, 2024
Merged
Add support for FSDP+QLoRA and DeepSpeed ZeRO3+QLoRA #1416
younesbelkada
merged 14 commits into
huggingface:main
from
pacman100:smangrul/fsdp+qlora
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much !
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
I can't repro the CI failure locally and on main, will fix in a follow up PR! |
kashif
pushed a commit
that referenced
this pull request
Mar 14, 2024
* don't do mp casting * don't use `prepare_for_kbit` when using fsdp+qlora or dsz3+qlora * changes to enable fsdp+qlora and dsz3+qlora * revert * Update sft_trainer.py * quality * fix deprecation using changes from PR #1415 * fixes * quality * Update trl/trainer/sft_trainer.py Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> * quality * relaunch tests --------- Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
kashif
pushed a commit
to fe1ixxu/trl
that referenced
this pull request
Mar 15, 2024
* don't do mp casting * don't use `prepare_for_kbit` when using fsdp+qlora or dsz3+qlora * changes to enable fsdp+qlora and dsz3+qlora * revert * Update sft_trainer.py * quality * fix deprecation using changes from PR huggingface#1415 * fixes * quality * Update trl/trainer/sft_trainer.py Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> * quality * relaunch tests --------- Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* don't do mp casting * don't use `prepare_for_kbit` when using fsdp+qlora or dsz3+qlora * changes to enable fsdp+qlora and dsz3+qlora * revert * Update sft_trainer.py * quality * fix deprecation using changes from PR huggingface#1415 * fixes * quality * Update trl/trainer/sft_trainer.py Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> * quality * relaunch tests --------- Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
prepare_model_for_kbit_training
andpeft_module_casting_to_bf16
should be disabled when using FSDP+QLoRA or DeepSpeed ZeRO3+QLoRA.This PR should be merged after Transformers PR huggingface/transformers#29587