Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move date cache to one thread and box date string to avoid threading issues #102

Closed
wants to merge 2 commits into from

Conversation

adam-fowler
Copy link
Member

Not sure if this is thread safe

@adam-fowler adam-fowler changed the title Move data cache to one thread and box date string to avoid threading issues Move date cache to one thread and box date string to avoid threading issues Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #102 (c35bee4) into main (4e338e2) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   82.91%   82.74%   -0.17%     
==========================================
  Files          58       58              
  Lines        2687     2684       -3     
==========================================
- Hits         2228     2221       -7     
- Misses        459      463       +4     
Impacted Files Coverage Δ
...rces/Hummingbird/Extensions/EventLoopStorage.swift 93.33% <ø> (ø)
Sources/Hummingbird/HTTP/MediaType.swift 93.97% <ø> (ø)
...urces/Hummingbird/Middleware/MiddlewareGroup.swift 100.00% <ø> (ø)
Sources/Hummingbird/Router/EndpointResponder.swift 81.81% <ø> (ø)
Sources/Hummingbird/Router/TrieRouter.swift 94.82% <ø> (ø)
Sources/Hummingbird/Server/Request.swift 96.36% <ø> (ø)
Sources/Hummingbird/Server/ResponsePatch.swift 85.71% <ø> (ø)
...rces/Hummingbird/Storage/MemoryPersistDriver.swift 77.77% <ø> (ø)
...on/Codable/URLEncodedForm/URLEncodedFormNode.swift 97.27% <ø> (ø)
Sources/HummingbirdFoundation/Files/FileIO.swift 90.72% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b4e89...c35bee4. Read the comment docs.

@adam-fowler
Copy link
Member Author

Looks like it isn't. Closing

@adam-fowler adam-fowler closed this Oct 7, 2021
@adam-fowler adam-fowler deleted the data-cache-rewrite branch October 6, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant