-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async versions of HBFileIO
api
#109
Conversation
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 68 69 +1
Lines 2916 2923 +7
=======================================
+ Hits 2430 2436 +6
- Misses 486 487 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far. Would you write tests for this?
Yeah should probably add some tests |
tests added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 👍
No description provided.