Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async versions of HBFileIO api #109

Merged
merged 4 commits into from
Oct 29, 2021
Merged

Async versions of HBFileIO api #109

merged 4 commits into from
Oct 29, 2021

Conversation

adam-fowler
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #109 (576f300) into main (a4f9921) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files          68       69    +1     
  Lines        2916     2923    +7     
=======================================
+ Hits         2430     2436    +6     
- Misses        486      487    +1     
Impacted Files Coverage Δ
...irdFoundation/AsyncAwaitSupport/FileIO+async.swift 66.66% <66.66%> (ø)
Sources/HummingbirdFoundation/Files/FileIO.swift 90.81% <100.00%> (+0.09%) ⬆️
Sources/HummingbirdJobs/MemoryJobQueue.swift 100.00% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f9921...576f300. Read the comment docs.

Copy link

@mcritz mcritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far. Would you write tests for this?

@adam-fowler
Copy link
Member Author

Yeah should probably add some tests

@adam-fowler
Copy link
Member Author

tests added

Copy link

@mcritz mcritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👍

@adam-fowler adam-fowler merged commit 6ea037d into main Oct 29, 2021
@adam-fowler adam-fowler deleted the async-fileio branch October 29, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants