Adjust file handling to handle loading from bundles #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to load files from a bundle of files passed to a test suite. In my server setup I had this middleware:
However whenever I requested a file from the
testData
bundleHBFileMiddleware
failed to find it.I debugged through and found that the string based root folder was being set to a
file:///...
path which was not understood by the file code attempting to load the file.This PR:
rootFolder
to be a file URL instead of a string.rootFolder
based on it now being a URL. ie.rootFolder.relativePath
./
which is no longer needed.Testing
After the code change all Hummingbird test ran green without change.