Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new test setup .asyncTest #144

Merged
merged 11 commits into from
Oct 30, 2022
Merged

Add new test setup .asyncTest #144

merged 11 commits into from
Oct 30, 2022

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Oct 6, 2022

Makes use of new NIOAsyncTestingChannel.
Fixed issues with NIOAsyncTestingChannel by temporarily adding a poll for result with timeout

@adam-fowler adam-fowler marked this pull request as draft October 6, 2022 10:52
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 78.00% // Head: 76.24% // Decreases project coverage by -1.75% ⚠️

Coverage data is based on head (e831e9a) compared to base (564f63f).
Patch coverage: 11.62% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   78.00%   76.24%   -1.76%     
==========================================
  Files          72       74       +2     
  Lines        3105     3187      +82     
==========================================
+ Hits         2422     2430       +8     
- Misses        683      757      +74     
Impacted Files Coverage Δ
Sources/Hummingbird/Configuration.swift 66.66% <ø> (ø)
Sources/HummingbirdXCT/HBXCT.swift 0.00% <0.00%> (ø)
Sources/HummingbirdXCT/HBXCTAsyncTesting.swift 0.00% <0.00%> (ø)
Sources/HummingbirdXCT/Application+XCT.swift 66.66% <16.66%> (-33.34%) ⬇️
Sources/HummingbirdXCT/HBXCTLive.swift 83.78% <100.00%> (+3.13%) ⬆️
Sources/HummingbirdJobs/MemoryJobQueue.swift 100.00% <0.00%> (+6.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adam-fowler adam-fowler marked this pull request as ready for review October 30, 2022 10:30
@adam-fowler adam-fowler merged commit 954e808 into main Oct 30, 2022
@adam-fowler adam-fowler deleted the feature/async-testing branch October 30, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant