Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HBRequest and HBResponse Sendable #145

Merged
merged 7 commits into from
Oct 31, 2022
Merged

Conversation

adam-fowler
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Base: 78.97% // Head: 78.93% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (e517fab) compared to base (954e808).
Patch coverage: 88.00% of modified lines in pull request are covered.

❗ Current head e517fab differs from pull request most recent head 4de6135. Consider uploading reports for the commit 4de6135 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   78.97%   78.93%   -0.04%     
==========================================
  Files          74       75       +1     
  Lines        3187     3205      +18     
==========================================
+ Hits         2517     2530      +13     
- Misses        670      675       +5     
Impacted Files Coverage Δ
Sources/Hummingbird/Router/Parameters.swift 54.05% <ø> (ø)
Sources/Hummingbird/Utils/FlatDictionary.swift 68.08% <ø> (ø)
Sources/Hummingbird/Extensions/Extensions.swift 72.97% <78.57%> (-5.29%) ⬇️
...Hummingbird/AsyncAwaitSupport/UnsafeTransfer.swift 100.00% <100.00%> (ø)
Sources/Hummingbird/Server/Request.swift 92.98% <100.00%> (ø)
Sources/Hummingbird/Server/Response.swift 71.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adam-fowler adam-fowler merged commit d1911d6 into main Oct 31, 2022
@adam-fowler adam-fowler deleted the feature/sendable-part2 branch October 31, 2022 10:08
@adam-fowler adam-fowler restored the feature/sendable-part2 branch November 23, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant