Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EventLoopStorage #151

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Remove EventLoopStorage #151

merged 2 commits into from
Nov 22, 2022

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Nov 22, 2022

It was added for redis and redis no longer needs it. I'm not a great fan of it anyway

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 79.16% // Head: 79.03% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (46b74a7) compared to base (6e91091).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   79.16%   79.03%   -0.13%     
==========================================
  Files          74       73       -1     
  Lines        3191     3162      -29     
==========================================
- Hits         2526     2499      -27     
+ Misses        665      663       -2     
Impacted Files Coverage Δ
Sources/Hummingbird/Application.swift 94.20% <ø> (-0.09%) ⬇️
Sources/Hummingbird/Utils/FlatDictionary.swift 68.08% <ø> (ø)
Sources/HummingbirdXCT/Application+XCT.swift 70.00% <ø> (ø)
...mmingbird/ConnectionPool/ConnectionPoolGroup.swift 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adam-fowler adam-fowler merged commit e97e7e6 into main Nov 22, 2022
@adam-fowler adam-fowler deleted the remove/event-loop-storage branch November 22, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant