Split up HBRequestContext from HBRequest #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't wait to try this out @Joannis 👍 |
adam-fowler
reviewed
Oct 3, 2023
|
|
||
| /// Request ID (Uses ID attached to loggger to avoid replication) | ||
| public var id: String { self.logger[metadataKey: "hb_id"]!.description } | ||
| public let id: String |
There was a problem hiding this comment.
Is this something we can move to context as well? I was kind of hoping we could ditch HBRequest for HBHTTPRequest. The ID was something you asked for initially what was the intention for it.
There was a problem hiding this comment.
In fact the id is stored in both request and context at the moment
| self.uri = uri | ||
| self.version = version | ||
| self.method = method | ||
| self.headers = headers | ||
| self.applicationContext = applicationContext | ||
| self.context = context | ||
| self.endpointPath = .init(endpointPath) |
There was a problem hiding this comment.
Similar to id any reason we can't move endpointPath to the context as well
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.