Get rid of global iso8601 formatter #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not thread safe on Linux
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 84.66% 84.67% +0.01%
==========================================
Files 78 78
Lines 4831 4830 -1
==========================================
Hits 4090 4090
+ Misses 741 740 -1 ☔ View full report in Codecov by Sentry. |
tib
reviewed
Nov 14, 2023
I checked and it isn't an issue. We can't leave it as is, because it is not thread safe and can cause crashes. |
Yes I agree. Thanks for the quick answer. |
tib
approved these changes
Nov 14, 2023
Joannis
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not thread safe on Linux