2.x.x - Add HBApplication.init(router:...) #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #329 +/- ##
==========================================
- Coverage 83.13% 83.11% -0.02%
==========================================
Files 92 91 -1
Lines 5009 5009
==========================================
- Hits 4164 4163 -1
- Misses 845 846 +1 ☔ View full report in Codecov by Sentry. |
|
Pull request benchmark comparison [ubuntu-latest] with '2.x.x' run at 2024-01-03T14:34:21+00:00 |
Joannis
reviewed
Jan 2, 2024
Is that an approval then 😄 ? |
Need to make HBRouterResponder public and explicitly return it from `buildResponder` to get this to work
adam-fowler
force-pushed
the
app-router-init
branch
from
5fd89fa
to
41a8228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
HBApplication(router:server:configuration:eventLoopGroupProvider:). Removes requirement for callingbuildRespondertherefore cleaner APINeed to make HBRouterResponder public and explicitly return it from
buildResponderto get this to work