2.x.x - Change parameter capture syntax to same as OpenAPI

[adam-fowler]

In v1.0 to support prefix and suffix URI parameters we added a new syntax for defining extracted parameters ${parameter}. Since then the OpenAPI runtime has come on line and it seems more sensible to duplicate the syntax OpenAPI has {parameter}. ie remove the $

[Joannis]

I don't mind this change, it makes the ecosystem more consistent. My main worry is about needing a clear note in docs for migrating older users

[adam-fowler]

I don't mind this change, it makes the ecosystem more consistent. My main worry is about needing a clear note in docs for migrating older users

I understand your concern. But being consistent is probably a good thing and if there is any time to change this kind of thing it is a major release. We can make sure to be clear about this change in the release notes and any migration docs.

[adam-fowler]

@tib given you were involved in the original decision regarding prefix and suffix capture parameters. How do you feel about changing it from ${param} to {param} to be more consistent with open api.

[Joannis]

I'm for the change, let's make an issue for the (migration) docs though

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e3b93d) 83.08% compared to head (15eb3d1) 83.07%.

Additional details and impacted files

@@            Coverage Diff             @@
##            2.x.x     #331      +/-   ##
==========================================
- Coverage   83.08%   83.07%   -0.02%     
==========================================
  Files          92       92              
  Lines        5037     5034       -3     
==========================================
- Hits         4185     4182       -3     
  Misses        852      852              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Pull request benchmark comparison [ubuntu-latest] with '2.x.x' run at 2024-01-11T06:43:03+00:00
Pull request had performance regressions