Generic request decoder and response encoder #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #353 +/- ##
==========================================
- Coverage 83.73% 83.63% -0.10%
==========================================
Files 93 92 -1
Lines 5059 5047 -12
==========================================
- Hits 4236 4221 -15
- Misses 823 826 +3 ☔ View full report in Codecov by Sentry. |
Joannis
approved these changes
Jan 19, 2024
Comment on lines
+64
to
+65
| associatedtype Decoder: HBRequestDecoder = NullDecoder | ||
| associatedtype Encoder: HBResponseEncoder = NullEncoder |
There was a problem hiding this comment.
Does it make sense to make these primary associated types?
There was a problem hiding this comment.
I'm not sure that is necessary. When are you going to need to specify the encoder in a parameter type
Comment on lines
+64
to
+65
| associatedtype Decoder: HBRequestDecoder = NullDecoder | ||
| associatedtype Encoder: HBResponseEncoder = NullEncoder |
There was a problem hiding this comment.
This will need fixing in HBLambda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring we store a request decoder and response encoder in the core context. This PR makes them accessible from the root of
HBRequestContext. This allows us to make them to be generic and not existential types.It does mean we have to get rid of
HBSetCodableMiddleware, but I think making these generic is a bigger gain.