Make HTTP handler non-throwing. Application should do error handling #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
force-pushed
the
server-non-throwing-handler
branch
from
0fe2633
to
76c6447
Compare
Joannis
reviewed
May 29, 2024
| @@ -115,6 +115,7 @@ extension ApplicationProtocol { | |||
| response = httpError.response(allocator: channel.allocator) | |||
| default: | |||
| // this error has not been recognised | |||
| context.logger.debug("Error: \(error)") | |||
There was a problem hiding this comment.
Given recent discussions on slack between Gwynne and Johannes, I think we should consider adding the error as metadata, clarifying the debug message, and make the main message a constant string.
There was a problem hiding this comment.
My bad. I meant to do that. I remember a long conversation when swift-log was first being setup which said pretty much the same thing
Joannis
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.