Add initializer for HTTPFields that reserves space for standard headers #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahdiBM
reviewed
May 25, 2024
| /// - Parameters: | ||
| /// - contentType: Content Type header | ||
| /// - contentLength: Content Length | ||
| init( |
There was a problem hiding this comment.
I'd prefer a static func like static func withExtraCapacity / static func withExtraReservedCapacity for better readabilty/clarity, even though this is only an internal function, unless it makes some kind of non-insignificant difference in the compiled code (I know inits have some special properties, but i've never cared enough for such optimizations to actually go after it)
There was a problem hiding this comment.
Fair enough wasn't totally happy with the init I must say.
Joannis
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.