Router Bugfixes #479
Merged
Router Bugfixes #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tibor Bodecs <mail.tib@gmail.com>
…nd different paths Move all logic into a ResolveContext. When encountering a dead end, the router goes back up the chain and descends another child. When a catch-all finds a new route to descend, store the nextNodeIndex so that the path can be descended further
|
This PR moves a lot of logic into a new struct. I don't know if it has a performance impact yet, so I might need to undo that |
adam-fowler
reviewed
Jun 18, 2024
adam-fowler
approved these changes
Jun 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.