Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store DateCache in TLS #56

Merged
merged 11 commits into from
Mar 8, 2021
Merged

Store DateCache in TLS #56

merged 11 commits into from
Mar 8, 2021

Conversation

adam-fowler
Copy link
Member

Moved DateCache to thread local storage as it is quicker to access than via the EventLoopStorage
Also wrote RFC1123 formatter without using Foundation, so we can move it to Hummingbird

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #56 (5eda422) into main (00dd64f) will increase coverage by 0.11%.
The diff coverage is 98.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   82.96%   83.08%   +0.11%     
==========================================
  Files          47       46       -1     
  Lines        2319     2353      +34     
==========================================
+ Hits         1924     1955      +31     
- Misses        395      398       +3     
Impacted Files Coverage Δ
Sources/Hummingbird/Utils/HBParser.swift 78.15% <ø> (ø)
Sources/Hummingbird/Application.swift 92.45% <83.33%> (-1.17%) ⬇️
...rces/Hummingbird/Extensions/EventLoopStorage.swift 93.33% <100.00%> (-6.67%) ⬇️
Sources/Hummingbird/Router/RouterMethods.swift 87.50% <100.00%> (ø)
...Hummingbird/Server/Application+HTTPResponder.swift 84.84% <100.00%> (+0.47%) ⬆️
Sources/Hummingbird/Utils/DateCache.swift 100.00% <100.00%> (ø)
...s/HummingbirdFoundation/Utils/DateCache+Date.swift 100.00% <100.00%> (ø)
Sources/HummingbirdXCT/HBXCTLive.swift 90.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00dd64f...3eebf15. Read the comment docs.

@adam-fowler adam-fowler merged commit d2b32c3 into main Mar 8, 2021
@adam-fowler adam-fowler deleted the tls-date-cache branch March 8, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant