Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HBRequestContext for extracting EventLoop, ByteBufferAllocator #72

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

adam-fowler
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #72 (074cc60) into main (c90715c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   82.84%   82.84%   -0.01%     
==========================================
  Files          52       52              
  Lines        2501     2500       -1     
==========================================
- Hits         2072     2071       -1     
  Misses        429      429              
Impacted Files Coverage Δ
...Hummingbird/Server/Application+HTTPResponder.swift 100.00% <100.00%> (ø)
Sources/Hummingbird/Server/Request.swift 94.11% <100.00%> (-0.17%) ⬇️
Sources/HummingbirdFoundation/Files/FileIO.swift 90.72% <100.00%> (ø)
...s/HummingbirdFoundation/Files/FileMiddleware.swift 92.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90715c...074cc60. Read the comment docs.

@adam-fowler adam-fowler merged commit 26fc603 into main Apr 21, 2021
@adam-fowler adam-fowler deleted the request-context branch April 21, 2021 10:24
adam-fowler added a commit that referenced this pull request Apr 26, 2021
* New HBRequestContext protocol

* Fix up FileIO after new HBRequestContext protocol added

* Fix FileTests

* swift format
adam-fowler added a commit that referenced this pull request Apr 26, 2021
* Add HBRequestContext for extracting EventLoop, ByteBufferAllocator (#72)

* New HBRequestContext protocol

* Fix up FileIO after new HBRequestContext protocol added

* Fix FileTests

* swift format

* Create my own context object instead of using ChannelHandlerContext

as ChannelHandlerContext is not thread safe

* comment

* swift format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant