Async/Await #76
Merged
Async/Await #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 82.57% 82.57%
=======================================
Files 53 53
Lines 2599 2599
=======================================
Hits 2146 2146
Misses 453 453
Continue to review full report at Codecov.
|
adam-fowler
force-pushed
the
async-await-stage1
branch
2 times, most recently
from
5e6a581
to
b9f414f
Compare
adam-fowler
force-pushed
the
async-await-stage1
branch
from
b9f414f
to
df01c63
Compare
adam-fowler
force-pushed
the
async-await-stage1
branch
from
1eb878b
to
5d61be6
Compare
adam-fowler
force-pushed
the
async-await-stage1
branch
5 times, most recently
from
c4e29a9
to
164408b
Compare
So code compiles with swift 5.4 and earlier and compiles for earlier versions of OS's
for async/await support
adam-fowler
force-pushed
the
async-await-stage1
branch
from
c428d29
to
a2f4781
Compare
Use 5.5 nightly
adam-fowler
force-pushed
the
async-await-stage1
branch
from
a2f4781
to
3a65d6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add async versions of
HBRouterMethodsget,put,postetc methodsAdd
HBAsyncCallbackResponderAdd
HBAsyncRouteHandlerAdd
HBAsyncMiddlewareThis is a non optimal solution at the moment. We require the custom executor support being promised and for NIO to use it before we get equivalent performance from async/await.