-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support copying individual profiles or a whole Store #159
Conversation
bd9f686
to
92b84b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes seem very useful!
Need to make sure we also add these changes to the JS wrapper, but the changes surface of API seems quite small.
One question: Something in noticed with profile is that if I open a session for a profile that does not exist, it will not throw an error until a record is actually inserted of fetched from that session. This means I have to check whether a profile exists before opening, which is possible by calling createProfile
. Or we have to fetch something to see if it works. I see some changes to the implementation of profiles, does this PR affect that behvaiour in any way?
What we do with normal wallets is that we try to open them, and if it fails we create them. This allows us to open it directly in all cases except the first time. While now we have to do a check every time that will fail everytime except the first time. It would be useful if opening a session would fail if the profile does not exist yet.
If this PR does not affect this at all, I can also open a separate issue for it
55c594c
to
315cd52
Compare
@TimoGlastra Thanks for opening the issue. This PR doesn't change that behaviour (although it adds some profile-related methods) but it's a good one to fix for 0.3. |
…py profiles between stores Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
315cd52
to
f593e18
Compare
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
4df32d4
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Support copying individual profiles or a whole Store
Fixes #18
Also adds methods to get and set the default profile (opened when none is specified).