Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reliability improvements #43

Merged
merged 43 commits into from
Apr 19, 2022
Merged

Reliability improvements #43

merged 43 commits into from
Apr 19, 2022

Conversation

andrewwhitehead
Copy link
Member

  • Fix intermittent Not Found error when repeatedly updating existing rows (Postgres / Sqlite)
  • Fix occasional memory access errors when using the Python wrapper
  • Add unit tests for contention between transactions
  • Add connection options for Sqlite backend (locking mode, journal mode, synchronized flag)
  • Update to sqlx 0.5.12
  • Update version to 0.2.5

@andrewwhitehead
perform replace in postgres without removing original row
5c2c333 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
additional performance tests
743f594 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
test multi-threaded row updates
44a05dd 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
update version to 0.2.5
e85de6f 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
try disabling lto
9db0d1e 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
always enable shared cache in sqlite
5352005 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
reduce tested threads
61db341 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
remove multi-threaded test
8a1253f 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
add contention test in rust; test python wrapper on postgres; disable…
9a0d98f 
… fail-fast

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
(postgres) use update instead of delete & insert
5f5908c 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
implement additional connection options for sqlite
1caf494 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
adjust error message
78639a5 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
use update instead of delete & insert
a16054c 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
use stabilized Arc::increment_strong_count
29537df 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
updates to transaction stress tests
9bb57e6 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
update localkey test
0cb834c 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
reduce count
61ad3c4 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
workflow updates
f68c840 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
use async-lock instead of option-lock
6b1a849 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
adjust log level
cdd3341 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
use *const T in ArcHandle
2b947a6 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
use flag instead of mem::forget
2326873 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
python wrapper refactoring (ensure method argument types)
bba2ad1 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
require UnwindSafe instead of guaranteeing it
b20cf02 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
SecretBytes api updates
b2bac7f 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
reduce unsafe
9444045 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
update ArcHandle bounds
50f57a6 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
adjust SecretBytes construction
95d9a0b 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
rename for consistency
cfd722a 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
minor cleanup
7485ee2 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
skip contention tests on github
7e6a563 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
allow custom logger to be disabled after initialization
f4dd69d 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
move code into Lib class, apply finalizers
d556520 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
add docstrings
e9b3cf7 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
wait for callbacks on shutdown
3c9d2b5 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
refactor callback handling
049eec9 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
simpler ArcHandle load
479f5ef 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
update to sqlx 0.5.12
b7c5f5c 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
misc build updates
a001dda 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
re-enable lto
e7639df 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
update askar-crypto to 0.2.5
012bc9d 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
simplify Default for SqliteOptions
ce308eb 
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead
split up wrapper binding classes; fix circular references in finalize…
3a9135a 
…rs; add unit tests

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead andrewwhitehead merged commit 76fcda4 into hyperledger:main Apr 19, 2022
@andrewwhitehead andrewwhitehead deleted the fix/conc-upd branch April 19, 2022 01:07
jamshale pushed a commit to jamshale/aries-askar that referenced this pull request Aug 18, 2024
@andrewwhitehead
Merge pull request hyperledger#43 from andrewwhitehead/fix/conc-upd
bda3aba 
Reliability improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewwhitehead