Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup after GHA docker user #5253

Merged

Conversation

garyschulte
Copy link
Contributor

PR description

Docker actions that write to files during actions leave files in the repository owned by the docker user rather than the runner user. This leaves the runner filesystem in a state that makes non-docker actions fail.

Fixed Issue(s)

@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte force-pushed the bugfix/repolinter-docker-cleanup branch from 681e0eb to 0eb4940 Compare March 22, 2023 01:20
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte force-pushed the bugfix/repolinter-docker-cleanup branch 3 times, most recently from 907ef50 to 4fae941 Compare March 22, 2023 02:15
@garyschulte garyschulte merged commit 5bd75b4 into hyperledger:main Mar 22, 2023
@garyschulte garyschulte deleted the bugfix/repolinter-docker-cleanup branch March 22, 2023 02:34
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
* cheaply attempt to cleanup after docker user

Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* cheaply attempt to cleanup after docker user

Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants