Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle cases where dagger besuComponent is null #5465

Merged
merged 2 commits into from
May 17, 2023
Merged

handle cases where dagger besuComponent is null #5465

merged 2 commits into from
May 17, 2023

Conversation

garyschulte
Copy link
Contributor

PR description

fix cases where BesuCommand is constructed without a dagger context

Fixed Issue(s)

@garyschulte
handle cases where dagger besuComponent is null
16001c0 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

gfukushima
gfukushima approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gfukushima gfukushima merged commit 6ef5e75 into hyperledger:main May 17, 2023
@garyschulte garyschulte deleted the bugfix/no-dagger-plugin branch May 17, 2023 17:04
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@garyschulte @gfukushima @elenduuche
handle cases where dagger besuComponent is null (hyperledger#5465)
7465cbf 
Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@garyschulte @gfukushima @eum602
handle cases where dagger besuComponent is null (hyperledger#5465)
23049f9 
Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfukushima gfukushima gfukushima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyschulte @gfukushima