add missing check for static peers to allow them to exceed the connection limit #6316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
|
Gabriel-Trintinalia
requested changes
Dec 20, 2023
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthPeers.java
Outdated
Show resolved
Hide resolved
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthPeers.java
Outdated
Show resolved
Hide resolved
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthPeers.java
Show resolved
Hide resolved
Gabriel-Trintinalia
requested changes
Dec 20, 2023
ethereum/p2p/src/main/java/org/hyperledger/besu/ethereum/p2p/peers/PeerPrivileges.java
Outdated
Show resolved
Hide resolved
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
| LOG.trace("Disconnected EthPeer {}", peer); | ||
| if (peer.getReputation().getScore() > USEFULL_PEER_SCORE_THRESHOLD) { | ||
| LOG.debug("Disonnected USEFULL peer {}", peer); | ||
| } else if (!LOG.isTraceEnabled()) { |
There was a problem hiding this comment.
We are checking for isTraceEnabled but logging at the debug level, should we make it a trace?
There was a problem hiding this comment.
I missed the "!", is that on purpose? Do we log only if Trace is not enabled?
Gabriel-Trintinalia
approved these changes
Dec 20, 2023
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
In one place there was a check missing to allow static peers to exceed the connection limit.
Another improvement is that streamBestPeers() does only return fully validated peers.