Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes coverage job #723

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Fixes coverage job #723

merged 1 commit into from
Nov 16, 2020

Conversation

e-ivkov
Copy link
Contributor

@e-ivkov e-ivkov commented Nov 16, 2020

Signed-off-by: Egor Ivkov e.o.ivkov@gmail.com

Background

As you may have noticed our coverage CI job have failed recently, due to compilation errors.

With the new nightly version 1.49 rustc improvements (rust-lang/rust#77638) were introduced, that fail the compilation of our dependencies in nightly rust and our coverage tool uses nightly rust.

Description of the Change

Therefore it is needed to increment heim library version, where the problems are fixed in its dependency uom library.

Benefits

The master branch coverage job should work correctly after this fix.

Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
@e-ivkov e-ivkov requested a review from humb1t as a code owner November 16, 2020 15:57
@e-ivkov e-ivkov added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Nov 16, 2020
@e-ivkov e-ivkov self-assigned this Nov 16, 2020
@e-ivkov e-ivkov merged commit a905be0 into hyperledger:iroha2-dev Nov 16, 2020
@e-ivkov e-ivkov deleted the coverage-fix branch November 17, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants