Fix leaks in Python-ast.c (python#16127)

hyphinwang · Sep 14, 2019 · 0247e80 · 0247e80
1 parent 279f446
commit 0247e80
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/Parser/asdl_c.py b/Parser/asdl_c.py
@@ -638,9 +638,13 @@ def visitModule(self, mod):
 ast_dealloc(AST_object *self)
 {
     /* bpo-31095: UnTrack is needed before calling any callbacks */
+    PyTypeObject *tp = Py_TYPE(self);
     PyObject_GC_UnTrack(self);
     Py_CLEAR(self->dict);
-    Py_TYPE(self)->tp_free(self);
+    freefunc free_func = PyType_GetSlot(tp, Py_tp_free);
+    assert(free_func != NULL);
+    free_func(self);
+    Py_DECREF(tp);
 }
 
 static int

diff --git a/Python/Python-ast.c b/Python/Python-ast.c