Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable New Relic transaction introspection for celery #83

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Disable New Relic transaction introspection for celery #83

merged 1 commit into from
Dec 16, 2020

Conversation

jon-betts
Copy link
Contributor

For: #60

We're hoping it'll stop crashing our tasks if we do this.

Review notes

  • This is mostly the result of running newrelic-admin generate-config
  • We have no idea if this is actually the cause, but this could rule it out

Testing notes

Kind of tricky. You can get your own New Relic licence key and run:

  • NEW_RELIC_LICENSE_KEY=<whatever> make dev
  • You should see it doesn't crash
  • You can set log_level=debug in conf/newrelic.ini for more output

Disable New Relic transaction introspection for celery
518024f 
We're hoping it'll stop crashing our tasks if we do this
@jon-betts jon-betts added the bug Something isn't working label Dec 16, 2020
@jon-betts jon-betts requested a review from seanh December 16, 2020 13:29
@jon-betts jon-betts self-assigned this Dec 16, 2020
@jon-betts jon-betts merged commit e3db12f into main Dec 16, 2020
@jon-betts jon-betts deleted the no-new-relic-db-for-celery branch December 16, 2020 13:40
@seanh seanh mentioned this pull request Jan 22, 2021
Open
@seanh
Copy link
Contributor

seanh commented Jan 22, 2021

Should we revert this because #60 is still happening? (Just use the Revert button above)

seanh added a commit that referenced this pull request Apr 14, 2021
@seanh
Re-enable New Relic transaction tracing
96c6645 
This was disabled to try to fix an issue:

* #60
* #83

But the "SSL error: decryption failed or bad record mac" crash is still
happening in production.

* https://sentry.io/share/issue/d6a9cd75bf0e4a26963835984baf2e06/
* https://sentry.io/share/issue/434a72a65b2f402290d98fa0caa3b30c/
* https://sentry.io/share/issue/f8c25d28b2f946a8b286b324ff801ce4/
seanh added a commit that referenced this pull request Apr 14, 2021
@seanh
Re-enable New Relic transaction tracing
82150c8 
This was disabled to try to fix an issue:

* #60
* #83

But the "SSL error: decryption failed or bad record mac" crash is still
happening in production.

* https://sentry.io/share/issue/d6a9cd75bf0e4a26963835984baf2e06/
* https://sentry.io/share/issue/434a72a65b2f402290d98fa0caa3b30c/
* https://sentry.io/share/issue/f8c25d28b2f946a8b286b324ff801ce4/
@seanh seanh mentioned this pull request Apr 14, 2021
Merged
seanh added a commit that referenced this pull request Apr 14, 2021
@seanh
Re-enable New Relic transaction tracing
3355415 
This was disabled to try to fix an issue:

* #60
* #83

But the "SSL error: decryption failed or bad record mac" crash is still
happening in production.

* https://sentry.io/share/issue/d6a9cd75bf0e4a26963835984baf2e06/
* https://sentry.io/share/issue/434a72a65b2f402290d98fa0caa3b30c/
* https://sentry.io/share/issue/f8c25d28b2f946a8b286b324ff801ce4/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanh seanh seanh approved these changes

Assignees

@jon-betts jon-betts

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jon-betts @seanh