Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type definitions #1560

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Conversation

javiertury
Copy link
Contributor

  • Allow nullable "data" in BackendModule.read callback. According to the docs, callback(err, null) is valid.
  • BackendModule.create is optional.
  • BackendModule.readMulti should use MultiReadCallback instead of ReadCallback.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included <- Not needed (in my opinion)
  • documentation is changed or added <- Not needed (in my opinion)

- Make "data" in BackendModule.read callback nullable. According to the docs, callback(err, null) is valid.
- BackendModule.create is optional
- BackendModule.readMulti should use MultiReadCallback instead of ReadCallback
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.037% when pulling 9d77723 on javiertury:fix_type_definitions into 8d17fb1 on i18next:master.

@jamuhl jamuhl merged commit b3771d8 into i18next:master Feb 24, 2021
@jamuhl
Copy link
Member

jamuhl commented Feb 24, 2021

thank you for contributing - was published in i18next@19.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants