Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic airplane mixer images #1486

Merged
merged 5 commits into from
Mar 15, 2022
Merged

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Mar 13, 2022

A video says a million words, so click this. Note the coloured bars on the servo rows and outputs table are just video edits. The mixer colours have not changed. On the last change in the video I forgot to swap the blue and green colours in the servo mixer table, when the stabilised yaw was set to servo 12. But, you can see the numbers all match up.

The video has everything, except for the notice that the mixer is not loaded. So here's a screen shot of that.
image

First cut of code. It's pretty much there. I just need to decide how to handle changing the mixer type, then deciding to stick with the current mixer. Other than that, it's working as expected.
- Fixed issue where non-standard orders would not draw the output numbers.
- Added a refresh button to revert to current mixer after another mixer preset has been selected, but not loaded. This also has a prompt for assistance
- Fixed issue where changing the servo input would not update the outputs table.
@MrD-RC MrD-RC added this to the 5.0 milestone Mar 13, 2022
@wx4cb
Copy link

wx4cb commented Mar 13, 2022

you could do the whole row like in the video, but i think that just the "servo number" on the bottom part of the mixer would be enough

The servo number input boxes now change colour to match the outputs diagram.
@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Mar 13, 2022

image

@DzikuVx
Copy link
Member

DzikuVx commented Mar 14, 2022

Bug:

  1. Start with default

image

  1. Switch to Airplane
  2. Click Refresh mixer

image

Also:

  • Output Mapping table is never updated
  • I was able to get to the state when there was unknown.svg mixer page

@DzikuVx
Copy link
Member

DzikuVx commented Mar 14, 2022

Seems like most problem are caused when on initial state there is no mixer defined at all.

For example

image

This happened when Refresh mixer was clicked without any mixer rules

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Mar 14, 2022

Cool, I'll get on that. Seems like the check for the Refresh mixer needs to be more stringent.

- Re-assessed the mechanism to show the refresh button. It now only displays when there is an AIRPLANE mixer loaded.
- Refresh the platform select when refresh button is clicked to stop unknown mixer presets.
@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Mar 14, 2022

Bug fix resolution

@DzikuVx DzikuVx merged commit 1f322cd into master Mar 15, 2022
@DzikuVx DzikuVx deleted the MrD-Dynamic-Airplane-Mixer-Images branch March 15, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants