Add version number to CLI save filename #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the version number to the CLI filename. It also adds a secondary way to get the data from the FC if it is out of range. If it fails, it appears as the previous save filename looked.
DzikuVx
reviewed
Aug 14, 2022
js/helpers.js
Outdated
| if (CONFIG.name && CONFIG.name.trim() !== '') { | ||
| filename = filename + '_' + CONFIG.name.trim().replace(' ', '_'); | ||
| } | ||
| } else { | ||
| // Attempt to get the version number and | ||
| MSPHelper.getSetting("version").then(function (data) { |
There was a problem hiding this comment.
@MrD-RC are you sure this even works? When CLI is on, MSP on that port no longer works
There was a problem hiding this comment.
Test 1: Same version
Test 2: 4.1.0
Test 3:
You're right. It's using CONFIG each time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the version number to the CLI filename.
The version number is very handy for keeping track of the diff and dump saves. To be honest, I got bored of adding it all the time manually 😉