Fix naming of error and parameter

ibwei · May 11, 2020 · 9938cc1 · 9938cc1
1 parent 3f22d17
commit 9938cc1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/src/entities/trade.ts b/src/entities/trade.ts
@@ -115,31 +115,31 @@ export class Trade {
     this.slippage = getSlippage(route.midPrice, inputAmount, outputAmount)
   }
 
-  // get the minimum amount that must be received from this trade for the given allowed slippage
-  public minimumAmountOut(additionalSlippageTolerance: Percent): TokenAmount {
-    invariant(!additionalSlippageTolerance.lessThan(ZERO), 'ADDITIONAL_SLIPPAGE_TOLERANCE')
+  // get the minimum amount that must be received from this trade for the given slippage tolerance
+  public minimumAmountOut(slippageTolerance: Percent): TokenAmount {
+    invariant(!slippageTolerance.lessThan(ZERO), 'SLIPPAGE_TOLERANCE')
     if (this.tradeType === TradeType.EXACT_OUTPUT) {
       return this.outputAmount
     } else {
       return new TokenAmount(
         this.outputAmount.token,
         new Fraction(ONE)
-          .add(additionalSlippageTolerance)
+          .add(slippageTolerance)
           .invert()
           .multiply(this.outputAmount.raw).quotient
       )
     }
   }
 
-  // get the maximum amount in that can be spent via this trade for the given allowed slippage
-  public maximumAmountIn(additionalSlippageTolerance: Percent): TokenAmount {
-    invariant(!additionalSlippageTolerance.lessThan(ZERO), 'ADDITIONAL_SLIPPAGE_TOLERANCE')
+  // get the maximum amount in that can be spent via this trade for the given slippage tolerance
+  public maximumAmountIn(slippageTolerance: Percent): TokenAmount {
+    invariant(!slippageTolerance.lessThan(ZERO), 'SLIPPAGE_TOLERANCE')
     if (this.tradeType === TradeType.EXACT_INPUT) {
       return this.inputAmount
     } else {
       return new TokenAmount(
         this.inputAmount.token,
-        new Fraction(ONE).add(additionalSlippageTolerance).multiply(this.inputAmount.raw).quotient
+        new Fraction(ONE).add(slippageTolerance).multiply(this.inputAmount.raw).quotient
       )
     }
   }

diff --git a/test/trade.test.ts b/test/trade.test.ts
@@ -94,7 +94,7 @@ describe('Trade', () => {
       )
       it('throws if less than 0', () => {
         expect(() => exactIn.maximumAmountIn(new Percent(JSBI.BigInt(-1), JSBI.BigInt(100)))).toThrow(
-          'ADDITIONAL_SLIPPAGE_TOLERANCE'
+          'SLIPPAGE_TOLERANCE'
         )
       })
       it('returns exact if 0', () => {
@@ -121,7 +121,7 @@ describe('Trade', () => {
 
       it('throws if less than 0', () => {
         expect(() => exactOut.maximumAmountIn(new Percent(JSBI.BigInt(-1), JSBI.BigInt(100)))).toThrow(
-          'ADDITIONAL_SLIPPAGE_TOLERANCE'
+          'SLIPPAGE_TOLERANCE'
         )
       })
       it('returns exact if 0', () => {
@@ -150,7 +150,7 @@ describe('Trade', () => {
       )
       it('throws if less than 0', () => {
         expect(() => exactIn.minimumAmountOut(new Percent(JSBI.BigInt(-1), JSBI.BigInt(100)))).toThrow(
-          'ADDITIONAL_SLIPPAGE_TOLERANCE'
+          'SLIPPAGE_TOLERANCE'
         )
       })
       it('returns exact if 0', () => {
@@ -177,7 +177,7 @@ describe('Trade', () => {
 
       it('throws if less than 0', () => {
         expect(() => exactOut.minimumAmountOut(new Percent(JSBI.BigInt(-1), JSBI.BigInt(100)))).toThrow(
-          'ADDITIONAL_SLIPPAGE_TOLERANCE'
+          'SLIPPAGE_TOLERANCE'
         )
       })
       it('returns exact if 0', () => {