Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drop down not closing when inside scrollable #1496

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

tarkah
Copy link
Member

@tarkah tarkah commented Oct 28, 2022

Fix drop down not closing when inside scrollable and user clicks outside the scrollable. This is because the scrollable sets -1.0 on cursor.y for any events where cursor is outside it's bounds. I'm not sure why picklist had this logic to stay open on -1.0 / -1.0, any click outside the overlay should close it.

and user clicks outside the scrollable. This is because the scrollable
sets -1.0 on cursor.y for any events where cursor is outside it's
bounds. I'm not sure why picklist had this logic to stay open on -1.0 /
-1.0, any click outside the overlay should close it.
@hecrj hecrj added this to the 0.5.0 milestone Oct 28, 2022
@hecrj hecrj added the bug Something isn't working label Oct 28, 2022
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I believe this logic is a leftover from way before event capturing was a thing in the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants