Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fullscreen only works on primary monitor #1742

Merged
merged 3 commits into from
Mar 3, 2023
Merged

[Fix] Fullscreen only works on primary monitor #1742

merged 3 commits into from
Mar 3, 2023

Conversation

bungoboingo
Copy link
Contributor

@bungoboingo bungoboingo commented Mar 2, 2023 •
edited
Loading

This fixes a bug where window::change_mode Command was using only the primary monitor, not the current monitor. Also added a fullscreen/windowed hotkey to the Todos example

@bungoboingo bungoboingo force-pushed the fix/fullscreen branch 3 times, most recently from afbfac7 to e8d498e Compare March 2, 2023 18:35
@bungoboingo bungoboingo changed the title Fix/fullscreen on current monitor [Fix] Fullscreen only works on primary monitor Mar 2, 2023
@hecrj hecrj added bug Something isn't working shell labels Mar 3, 2023
@hecrj hecrj added this to the 0.9.0 milestone Mar 3, 2023
hecrj
hecrj approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Since we do not rely on iced_web anymore, we can expose the window commands for Wasm builds.

@hecrj hecrj merged commit d73ca4d into iced-rs:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working shell
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bungoboingo @hecrj