Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tiny-skia svg premultiply final filtered color #1841

Merged
merged 1 commit into from
May 9, 2023
Merged

fix: tiny-skia svg premultiply final filtered color #1841

merged 1 commit into from
May 9, 2023

Conversation

wash2
Copy link
Contributor

@wash2 wash2 commented May 9, 2023

If the color is pre-multiplied before grabbing the alpha of the pixel, then the filter color is leaked even what the pixel is completely transparent. This is noticeable if you disable wgpu and use the dark theme in the svg example.

@hecrj hecrj added bug Something isn't working rendering labels May 9, 2023
@hecrj hecrj added this to the 0.10.0 milestone May 9, 2023
hecrj
hecrj approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Here I was hoping there would be a way to avoid premultiplying every pixel...

Thanks! 🙇

@hecrj hecrj merged commit 422b4de into iced-rs:advanced-text May 9, 2023
@wash2 wash2 deleted the fix-svg-color-filter branch May 10, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working rendering
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wash2 @hecrj