Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run convert_text on svg trees so text renders correctly #1908

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

alec-deason
Copy link
Contributor

@alec-deason alec-deason commented Jun 10, 2023

Resvg will not render text unless .convert_text has been run on the tree first. This PR does that. This takes one approach to sharing the font database between the text pipeline and the vector pipeline but I'm open to alternatives.

Fixes #870.

@alec-deason alec-deason marked this pull request as ready for review July 12, 2023 20:45
@hecrj hecrj added bug Something isn't working rendering svg labels Jul 12, 2023
@hecrj hecrj added this to the 0.10.0 milestone Jul 12, 2023
@hecrj hecrj modified the milestones: 0.10.0, 0.11.0 Jul 28, 2023
@hecrj hecrj added the fix label Nov 11, 2023
`tiny-skia` does not support text rendering, so we
convert the text nodes to path nodes prior to that.
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of master. Thanks! 🙇

@hecrj hecrj enabled auto-merge November 11, 2023 03:05
@hecrj hecrj merged commit 3408ab1 into iced-rs:master Nov 11, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix rendering svg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invisible text in svgs after updating to 0.3.0
2 participants