Fix/scrollable touch input stuck #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Austin M. Reppert <austinmreppert@gmail.com>
hecrj
force-pushed
the
fix/scrollable-touch-input-stuck
branch
from
a45d96b
to
d72ac36
Compare
hecrj
force-pushed
the
fix/scrollable-touch-input-stuck
branch
from
6590a4a
to
4477537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix this scrollable touch input bug. The main "problem" seems to be exiting the event handler on a un-touch/touch loss returning immediately after handling it, even though later in the code the event is handled again. I have defaulted the return value to ignore and only return immediately when absolutely necessary, so that the various portions of the event handlers do not have to "fight" over the event.
bug.-.Trim.mp4