Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard subscriptions and rename subscription::events to event::listen #2073

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Add keyboard subscriptions and rename subscription::events to event::listen #2073

merged 2 commits into from
Sep 7, 2023

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Sep 7, 2023

This PR introduces on_key_press and on_key_release subscriptions in keyboard and renames the old subscription::events and its variants to event::listen.

@hecrj
Introduce keyboard::on_key_press and on_key_release
08a031c 
Also rename `subscription::events*` to `event::listen*`.
@hecrj hecrj added this to the 0.12.0 milestone Sep 7, 2023
@hecrj hecrj added the improvement An internal improvement label Sep 7, 2023
@hecrj hecrj enabled auto-merge September 7, 2023 00:50
@hecrj hecrj merged commit c8fed14 into master Sep 7, 2023
19 checks passed
@hecrj hecrj deleted the event-helpers branch September 7, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change improvement An internal improvement subscription
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
1 participant
@hecrj