Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wgpu: require Send on stored pipelines #2197

Merged
merged 1 commit into from
Jan 11, 2024
Merged

wgpu: require Send on stored pipelines #2197

merged 1 commit into from
Jan 11, 2024

Conversation

tzemanovic
Copy link
Contributor

hi, thanks for this awesome crate!

I'm using wgpu::Renderer/Backend with Send, but since pipeline_storage: pipeline::Storage was added to Backend it is no longer Send (#2085). I'd like to restore this by adding the extra bound, it still works with the examples/custom_shader/src/scene.rs.

hecrj
hecrj approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable! Thanks 🙇

@hecrj hecrj enabled auto-merge January 11, 2024 16:02
@hecrj hecrj added this to the 0.12 milestone Jan 11, 2024
@hecrj hecrj merged commit 89fc4f5 into iced-rs:master Jan 11, 2024
13 checks passed
tzemanovic added a commit to tzemanovic/bevy_iced that referenced this pull request Jan 12, 2024
@tzemanovic
upstreamed iced-rs/iced#2197
e1a397c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
change wgpu
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@tzemanovic @hecrj