Separate image widget support from image codecs. #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Thinking about this it may make more sense to enable the image widget by default, and turn the "image" feature into actual codec support in general. That way it would be a non-breaking change and still a win-win size wise. |
dtzxporter
added a commit
to dtzxporter/iced
that referenced
this pull request
Feb 12, 2024
This is a non-breaking change that allows using images loaded with a different library in your program, or raw pixel buffers without including all of the bloat that image-rs is. It's another attempt at iced-rs#2244 that is backwards compatible with existing applications because they will already use the image feature if they want the widget.
Co-authored-by: dtzxporter <dtzxporter@users.noreply.github.com>
hecrj
force-pushed
the
separate-image-widget-from-image-codecs
branch
from
d93b040
to
fa66610
Compare
hecrj
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimization with feature flags allows a couple of cases:
Now, the from_path and from_memory methods are gated and will only be present when one or more codec features are enabled.