Use generic Content in Text to avoid reallocation in fill_text
#2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
commented
Apr 1, 2024
| @@ -526,7 +526,7 @@ where | |||
|
|
|||
| renderer.fill_text( | |||
| Text { | |||
| content: &option.to_string(), | |||
| content: option.to_string(), | |||
There was a problem hiding this comment.
No more (&option.to_string()).to_string()! I will sleep tight tonight.
There was a problem hiding this comment.
Hey, since you're looking into this .to_string reallocations couldn't the text helper function avoid reallocation as well here:
Text::new(text.to_string())
I always tend to use Text::new(&self.some_str) instead of text(&self.some_str) because of this.
There was a problem hiding this comment.
Not if we want to keep the ToString compatibility (e.g. text(10)). Specialization hasn't landed yet in Rust.
There was a problem hiding this comment.
Didn't think of that. I guess I can always make my own helper! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renderer::fill_textasks for a&strjust to turn it into aString... Amazing.Let's get rid of that, shall we?