Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Subscription internals #2493

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Hide Subscription internals #2493

merged 3 commits into from
Jul 5, 2024

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Jul 5, 2024 •
edited
Loading

This PR hides the internals of the Subscription type, makes the API more consistent with Task, removes redundant constructors in favor of run and run_with_id, and introduces a new stream::channel helper in the root crate.

@hecrj
Hide Subscription internals
8bc49cd 
.. and introduce `stream::channel` helper
@hecrj hecrj added improvement An internal improvement feature New feature or request developer experience change addition labels Jul 5, 2024
@hecrj hecrj added this to the 0.13 milestone Jul 5, 2024
@hecrj hecrj enabled auto-merge July 5, 2024 00:20
@hecrj hecrj merged commit 978327f into master Jul 5, 2024
24 checks passed
@hecrj hecrj deleted the hide-subscription-internals branch July 5, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
addition change developer experience feature New feature or request improvement An internal improvement
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.
1 participant
@hecrj