-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 16 #144
React 16 #144
Conversation
I definitely want to get onto 16 but enzyme doesn't support it yet. |
Ah yeah, looks like we'll need to follow enzymejs/enzyme#1007 and enzymejs/enzyme#928. Looks like it won't be supported until they release v3 |
0acba1f
to
2b45c5d
Compare
Updated the other packages and rebased against master. @mathisonian if you're good with this click the button :) |
One of the cli tests is failing with |
Where did you see that particular error? I think I'm only seeing Enzyme-related failures. Also, why are Travis and Appveyor both running twice? |
In the travis build - it seems like the react-micro-bar-chart doesn't like react 16
It is their default setting to run twice like that, but we can probably change it to not |
I just tweaked some settings - hopefully they'll only run once for PRs now |
I removed |
I'm still seeing errors, now from I'll take a look at options a little later on today |
https://facebook.github.io/fixed-data-table/ seems legit |
That one is apparently not maintained either? facebookarchive/fixed-data-table#468 Whats the deal with table libraries? (╯°□°)╯︵ ┻━┻ |
Son of a
…________________________________
From: Matthew Conlen <notifications@github.com>
Sent: Thursday, September 14, 2017 7:53:18 PM
To: idyll-lang/idyll
Cc: Ben Clinkinbeard; Comment
Subject: Re: [idyll-lang/idyll] React 16 (#144)
That one is apparently not maintained either? facebookarchive/fixed-data-table#468<facebookarchive/fixed-data-table#468>
Whats the deal with table libraries? (s°□°)s ┻━┻
―
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#144 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAIkN5W98aJPkXfAstmwjDsJ1uGrEiZnks5sibxugaJpZM4PQgXz>.
|
This one looks like it has potential, and a simple but still powerful API which is a plus edit: forgot the link https://github.com/react-tools/react-table |
This updates the project to use react-16 (targeted against the
idyll-doc-updates
branch). Its a relatively minor change, but will be good to get in, and will potentially allow us to take advantage of the new error boundary features.There are some warnings being thrown by Victory (only in dev - not production) but they are aware and say they'll fix these in the next release FormidableLabs/victory#724