Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Linkify email address lists one-by-one #6315

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

larseggert
Copy link
Collaborator

Seems to work around a bug in mozilla/bleach.

Fixes #6307

@rjsparks
Copy link
Member

A different solution would have been to make linkify also operate on and return lists (or make a new filter named linkify_list), but unless this starts exploding joins in many places, the return isn't that high.

@rjsparks
Copy link
Member

Test fails are in selenium, which we'll investigate separetely.

@larseggert
Copy link
Collaborator Author

A different solution would have been to make linkify also operate on and return lists (or make a new filter named linkify_list), but unless this starts exploding joins in many places, the return isn't that high.

I tried that, but Django seemed to stringify the list when it gets passed to the filter.

@rjsparks rjsparks merged commit 303ff70 into ietf-tools:main Sep 15, 2023
6 of 7 checks passed
@larseggert larseggert deleted the fix-6307 branch September 15, 2023 15:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name rendering fail on email expansion page
2 participants