Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert agenda editor font change #6538

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

jennifer-richards
Copy link
Member

@jennifer-richards jennifer-richards commented Oct 25, 2023

Using the default fonts apparently moves components around enough that selenium tests fail. Until we remove / debug those, go back to the non-standard fonts on the agenda editor "session" elements.

The failing test was EditMeetingScheduleTests.test_edit_meeting_schedule

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #6538 (4b794a5) into main (f6a2d8c) will increase coverage by 0.13%.
Report is 38 commits behind head on main.
The diff coverage is 95.94%.

❗ Current head 4b794a5 differs from pull request most recent head 792365d. Consider uploading reports for the commit 792365d to get more accurate results

@@            Coverage Diff             @@
##             main    #6538      +/-   ##
==========================================
+ Coverage   88.70%   88.84%   +0.13%     
==========================================
  Files         290      284       -6     
  Lines       40440    40243     -197     
==========================================
- Hits        35874    35755     -119     
+ Misses       4566     4488      -78     
Files Coverage Δ
ietf/doc/views_conflict_review.py 97.05% <100.00%> (-0.07%) ⬇️
ietf/secr/meetings/forms.py 89.33% <ø> (+0.16%) ⬆️
ietf/secr/meetings/urls.py 100.00% <ø> (ø)
ietf/secr/meetings/views.py 83.57% <100.00%> (+0.05%) ⬆️
ietf/secr/urls.py 100.00% <ø> (ø)
ietf/submit/parsers/base.py 96.72% <100.00%> (+1.56%) ⬆️
ietf/submit/parsers/xml_parser.py 100.00% <ø> (ø)
ietf/utils/xmldraft.py 93.18% <100.00%> (+0.26%) ⬆️
ietf/submit/forms.py 79.10% <80.00%> (+0.07%) ⬆️
ietf/submit/parsers/plain_parser.py 92.85% <91.66%> (+0.70%) ⬆️

... and 2 files with indirect coverage changes

@jennifer-richards jennifer-richards changed the title reverting commits to investigate test failures - do not merge chore: Revert agenda editor font change Oct 25, 2023
@jennifer-richards jennifer-richards marked this pull request as ready for review October 25, 2023 17:41
@rjsparks rjsparks merged commit be4a6ef into ietf-tools:main Oct 25, 2023
7 checks passed
@jennifer-richards jennifer-richards deleted the test-failure-debugging branch October 27, 2023 03:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants