Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update group dependencies for new rfc model #6773

Merged
merged 10 commits into from
Dec 14, 2023
Merged

fix: Update group dependencies for new rfc model #6773

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6b5230e
fix: Avoid accessing slug when state is None
jennifer-richards Dec 13, 2023
05f701c
fix: ignore pre-rfc drafts as rfc-to-rfc references
jennifer-richards Dec 13, 2023
a3d09a8
fix: also ignore pre-rfc to pre-rfc refs
jennifer-richards Dec 13, 2023
a2008c1
chore: remove breakpoint
jennifer-richards Dec 13, 2023
368d525
fix: ignore subseries non-downrefs
jennifer-richards Dec 13, 2023
7d83576
fix: label nodes as RFCS when possible
jennifer-richards Dec 13, 2023
79b5f3b
fix: get "rfc" flag right
jennifer-richards Dec 13, 2023
2a20e34
chore: Remove comment, answer seems to be "no"
jennifer-richards Dec 13, 2023
db13860
refactor: Specify state type; drop redundant source doc type check
jennifer-richards Dec 14, 2023
fdaa6d3
refactor: Specify state type in old code
jennifer-richards Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: ignore subseries non-downrefs
  • Loading branch information
@jennifer-richards
jennifer-richards committed Dec 13, 2023
commit 368d525f71b2ebc5910e85e2e591aabc8df25018
4 changes: 2 additions & 2 deletions ietf/group/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,8 +764,8 @@ def dependencies(request, acronym, group_type=None):

links = set()
for x in relations:
target_state = x.target.get_state_slug("draft")
if target_state != "rfc" or x.is_downref():
always_include = x.target.type_id not in rfc_or_subseries and x.target.get_state_slug("draft") != "rfc"
if always_include or x.is_downref():
links.add(x)

replacements = RelatedDocument.objects.filter(
Expand Down