Tracked series of breaking changes in Zig master #49
+54
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ifreund
approved these changes
Jul 20, 2023
| @@ -35,7 +35,7 @@ pub const Array = extern struct { | |||
| pub fn slice(array: Array, comptime T: type) []T { | |||
| const data = array.data orelse return &[0]T{}; | |||
| // The wire protocol/libwayland only guarantee 32-bit word alignment. | |||
| const ptr = @ptrCast([*]T, @alignCast(4, data)); | |||
| const ptr: [*]T = @ptrCast(@alignCast(data)); | |||
There was a problem hiding this comment.
This change as-is will no longer give a compile error if the alignment of T is greater then 4 but rather silently fail at runtime.
I think I'll change this function to return []align(4) T and let the user of zig-wayland handle underalignment as they like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current zig master version is 0.11.0-dev.3952+82a9d5d78.
All codes including examples are compiling with no errors.
Tracked: