Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChatMarkersManager improved - part 2 #272
base: master
Are you sure you want to change the base?
ChatMarkersManager improved - part 2 #272
Changes from 3 commits
e0998b4
0e57a9e
584aafb
49a97bb
1b4bc25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect that the user gives as a message with a markable extension to such a method. Then you could remove the
ChatMarkersState
andString
(messageId
) parameters, which would make the method much more user friendly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the user would need to deal with
message.addExtension(new ChatMarkersElements.ReceivedExtension(messageId));
by himself, in other words he would doing some of the job that this class has to do.What I want is class that can be used almost out of the box but of course knowing how the XEP works.