fix: remove bogus sampling rate check #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plutosdr only accepts a value of datatype integer as sampling rate. For this, there already is a conversion logic, to convert float data type sampling rate values to integer data type. However, the conversion logic is flawed, as it only triggers for values of float data type **if the floating point number has decimals** (digits behind the dot). Therefore, values of floating point data type like `10` or `25000` are not converted to an integer data type, resulting in failure to initialize the plutosdr. This patch removes the bogus check, always converting to integer type. This is a fix to igorauad#38 /
|
@igorauad Any chance that you take a look at this? |
|
@wucke13 thanks a lot for the PR. I ended up choosing a slightly different approach in 130c315. To avoid confusion, I'm checking for integer sample rates directly at the arguments parser. The parser won't let the application run if the chosen sample rate is non-integer with the PlutoSDR. Let me know if you still have any problems after that. Thanks again! |
|
@igorauad great to see some movement here! I guess your approach is ok. It still bugs me to make the sampling rate a float, which then is checked for figures after the digit, but I guess the logic is sound now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plutosdr only accepts a value of datatype integer as sampling rate. For this, there already is a conversion logic, to convert float data type sampling rate values to integer data type. However, the conversion logic is flawed, as it only triggers for values of float data type if the floating point number has decimals (digits behind the dot). Therefore, values of floating point data type like
10or25000are not converted to an integer data type, resulting in failure to initialize the plutosdr.This patch removes the bogus check, always converting to integer type.
This is a fix to #38