-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad module resolution (#42) #43
Conversation
Update from master
Why does is fail on AppVeyor? Looks like it does not copy package from |
AppVeyor uses Windows, if that is not what you use, maybe there is a path issue there? Regarding the _ APIs, aren’t those undocumented and unsupported? That worries me, as does the Node 8 requirement. I would love if we could figure out a way to get the right behavior on Node 6 with public APIs. |
Node 8 is not required. To replace |
That’s fair, thank you. I’ll have a look at this soon for a new release. I do want to understand the CI failure, though. |
Tests fixed, seems to an issue with |
Yay!! (Did you mean to leave that console.log in the code?) |
I should be able to accept this PR tonight. I’ll also update the markdownlint dependency and investigate the other open issue. Once done, I’ll publish a new version. Thanks for the help! |
Replace
require.resolve('packagename')
, which looks for packages relative to markdownlint-cli root, withrequire.resolve('packagename', {paths})
, where paths are calculated relative to working directory