Use Base64.strict_encode64 instead of Base64.encode64. #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Base64.encode64 adds line feeds every 60 encoded characters - Base64.strict_encode64 does not insert line feeds, so use it
|
Most decoders will ignore whitespace, but not all of them. |
igrigorik
added a commit
that referenced
this pull request
Mar 26, 2015
Use Base64.strict_encode64 instead of Base64.encode64.
|
That's a fun gotcha.. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when encoding a basic authorization header passed as an array
Base64.encode64is used. This is fine as long as the username and password being encoded are under 60 characters combined.Base64.encode64inserts line feeds every 60 encoded characters.This pull request simply uses
Base64.strict_encode64anywhere thatBase64.encode64was previously used. This behaves the same way, but without the insertion of line feeds every 60 encoded characters.