TouchableNativeFeedback.Ripple is not a function

[chris-aeviator]

Describe the bug
When upgrading expo from SDK V.39 to SDK V.41 I'm following the upgrade V1->V2 instructions for expo-video-player. However after migration, a previously working video player throws TouchableNativeFeedback.Ripple is not a function on expo-web.

To Reproduce
Steps to reproduce the behavior:

1. Load VideoPlayer with expo-sdk v.41 in expo web

Expected behavior
The video player should still load after the upgrade

Additional infofmation:

• Type: Expo web
• Device: Desktop
• OS: Arch Linux / Firefox V88
• Package Version: 2.0.0
• Expo version: 41.0.0
• Expo CLI version: : 4.5.2

[chris-aeviator]

I propose that

<TouchableNativeFeedback onPress={togglePlay} background={TouchableNativeFeedback.Ripple('white', true)}>

becomes

<TouchableNativeFeedback onPress={togglePlay} background={TouchableNativeFeedback?.Ripple('white', true) ?? null}>

[ihmpavel]

Hi,
while releasing v2 i did not check properly the web version.

During this week I'll try to focus and fix all possibly errors.

Maybe as temporary fix not to throw an error in the application I should release patch fix today.

[chris-aeviator]

Nice to hear that, and glad you want to keep support up for the web version.

https://stackoverflow.com/questions/43244306/react-native-touchablenativefeedback-ripple-is-not-function

suggests to use TouchableHighlight or TouchableOpacity

[ihmpavel]

Hi,
I have changed the code to reflect user platform. On Android, buttons are <TouchableNativeFeedback /> and on other platforms I changed the buttons to <TouchableOpacity />. I am not sure about the visual experience using <TouchableOpacity />. What do you think? Is it ok or should I use other Touchable element?

I created PR with the changes.

Let me know, what do you think. I am ready to create patch release immediately.

[chris-aeviator]

@ihmpavel I will check this tomorrow - for my current release I completely removed the Ripple but I'm happy to try this in the morning tomorrow! Thx!

[ihmpavel]

Merged into master. Version 2.0.1 #434